diff --git a/lambda-test/alert-test.c b/lambda-test/alert-test.c index 5abdbd1..e7b143a 100644 --- a/lambda-test/alert-test.c +++ b/lambda-test/alert-test.c @@ -21,7 +21,7 @@ beepCount = 0; oscCount = 0; - // alert with two beep2 with a length of 2 and tone 31 + // alert with two beeps with a length of 2 and tone 31 alert(2, 2, 31, "a", "b"); oscillateBeep(); oscillateBeep(); diff --git a/lambda-test/interrupts-test.c b/lambda-test/interrupts-test.c index 13d257b..4dd5e09 100644 --- a/lambda-test/interrupts-test.c +++ b/lambda-test/interrupts-test.c @@ -68,7 +68,7 @@ assertTrue(bit_is_set(TCCR1B, CS11)); // toggles PB1 at 7.8 kHz generating a 3.9 kHz beep // assertTrue(OCR1A == 15); - // 1.8 kHz is less noisy on the small piezo beeper + // 2 kHz is less noisy on the small piezo beeper assertTrue(OCR1A == 31); return true; diff --git a/lambda/TODO b/lambda/TODO index c11df0e..54e5991 100644 --- a/lambda/TODO +++ b/lambda/TODO @@ -1,9 +1,6 @@ * C -- Use static global vars + getter or extern in tests? -- Use const for "final" function parameters - Check other use of const (return value?) - Flexarray? http://en.wikipedia.org/wiki/Sizeof -- License? (github) * AVR - What happens if USART data is sent to the AVR too fast (GtkTerm Send Raw File) diff --git a/lambda/alert.c b/lambda/alert.c index f424089..1b7e7f6 100644 --- a/lambda/alert.c +++ b/lambda/alert.c @@ -50,7 +50,7 @@ beepLength = length; } -void alert(uint8_t const beeps, uint8_t const length, uint16_t tone, +void alert(uint8_t const beeps, uint8_t const length, uint16_t const tone, char* const line0, char* const line1) { OCR1A = tone; if (TCNT1 >= tone) TCNT1 = 0; diff --git a/lambda/interrupts.c b/lambda/interrupts.c index 29a4efc..3b2a509 100644 --- a/lambda/interrupts.c +++ b/lambda/interrupts.c @@ -53,12 +53,10 @@ } } -// TODO doesn't really belong in this source file bool isUSARTReceived(void) { return usartReceived; } -// TODO doesn't really belong in this source file void getUSARTData(char* const data, size_t const size) { if (size > 0) { data[0] = '\0'; @@ -81,7 +79,6 @@ void setupPorts(void) { // pull-up resistor for the mouton - // INT0 and INT1 are assigned to the LCD, a bit of a shame PORTB |= (1 << PB0); // enable beep output pin @@ -120,6 +117,6 @@ TCCR1B |= (1 << CS11); // toggles PB1 at 7.8 kHz generating a 3.9 kHz beep // OCR1A = 15; - // 1.8 kHz is less noisy on the small piezo beeper + // 2 kHz is less noisy on the small piezo beeper OCR1A = 31; }